This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
Fix random failure in OgMembershipTest::testGetSetCreatedTime(). #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CreatedItem::applyDefaultValue() is responsible for setting the created time on a newly created entity but still depends on the deprecated REQUEST_TIME constant. Switch back to this to avoid random failures when the time service is instantiated one second after the request time is set.
MPParsley
approved these changes
May 12, 2019
This was referenced May 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreatedItem::applyDefaultValue()is responsible for setting the created time on a newly created entity but still depends on the deprecatedREQUEST_TIMEconstant. Switch back to this to avoid random failures when the time service is instantiated one second after the request time is set.Fixes #502